Skip to content

Commit

Permalink
Remove unnecessary 'return'
Browse files Browse the repository at this point in the history
Better to remove 'return' before 'reject' in two example code pieces. This 'return' doesn't make sense.
Also, there is no such 'return' keyword in English version of this article.
This mistake in example code makes difficult to beginners to understand the code, distracts attention, creates questions in comments.
  • Loading branch information
nat-k-dev committed Jun 14, 2022
1 parent 098c554 commit d5a99dd
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions 1-js/11-async/06-promisify/article.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ function promisify(f) {
return new Promise((resolve, reject) => {
function callback(err, result) { // наш специальный колбэк для f
if (err) {
return reject(err);
reject(err);
} else {
resolve(result);
}
Expand Down Expand Up @@ -84,7 +84,7 @@ function promisify(f, manyArgs = false) {
return new Promise((resolve, reject) => {
function *!*callback(err, ...results*/!*) { // наш специальный колбэк для f
if (err) {
return reject(err);
reject(err);
} else {
// делаем resolve для всех results колбэка, если задано manyArgs
*!*resolve(manyArgs ? results : results[0]);*/!*
Expand Down

0 comments on commit d5a99dd

Please sign in to comment.