Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update repository URL for Atomix #184

Merged

Conversation

jrhenderson1988
Copy link
Contributor

Atomix is currently categorised as Java but it's actually written in Go.

@ongardie
Copy link
Member

Thanks @jrhenderson1988. It looks like the old Atomix has been archived to https://github.com/atomix/atomix-archive. Do you mind forking the entry into two: the old one in Java and the new one in Go?

@jrhenderson1988
Copy link
Contributor Author

Absolutely @ongardie. Happy to fork into two entries. However, after a quick dig into the Go version of Atomix, I'm not actually sure whether the project itself implements Raft or whether it just uses other open source Raft implementations.

For example, see here - it looks like that particular module is using Dragonboat. However, this module doesn't seem to be importing an existing library. To be honest, I'm not familiar enough with the Atomix project to work out whether or not it's a fit. Do you have any thoughts or opinions on this?

@ongardie
Copy link
Member

Looks to me like it's using Dragonboat. https://atomix.io/user-guide/deployment/data-stores/consensus/ also describes it that way. So maybe the right thing to do here is just to point the single JSON entry over to https://github.com/atomix/atomix-archive.

@jrhenderson1988 jrhenderson1988 changed the title Correct language for Atomix Update repository URL for Atomix Mar 23, 2023
@jrhenderson1988
Copy link
Contributor Author

That makes sense. I've updated the PR to point to the archived repo. I've also updated the name to hopefully make it clear that we mean the archived Java project, rather than the active Go version. Hope that makes sense. Happy to make further changes if you'd like.

@ongardie ongardie merged commit 00bf9d0 into raft:main Mar 27, 2023
@ongardie
Copy link
Member

Merged, thanks for the research and followups @jrhenderson1988

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants