Fixed specifying source file type manually in RasterStack

[yvikhlya]

This PR is supposed to fix #356

[codecov-commenter]

Codecov Report

Merging #359 (845498e) into main (4a09859) will decrease coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #359      +/-   ##
==========================================
- Coverage   79.20%   79.17%   -0.04%     
==========================================
  Files          38       38              
  Lines        3121     3121              
==========================================
- Hits         2472     2471       -1     
- Misses        649      650       +1     

Impacted Files	Coverage Δ
src/convenience.jl	75.00% <100.00%> (ø)
src/create.jl	94.44% <100.00%> (ø)
src/stack.jl	80.13% <100.00%> (ø)
src/write.jl	89.47% <100.00%> (-0.53%)	⬇️
src/sources/gdal.jl	83.56% <0.00%> (-0.80%)	⬇️
src/methods/mask.jl	89.65% <0.00%> (ø)
src/methods/trim.jl	95.65% <0.00%> (ø)
src/methods/warp.jl	89.65% <0.00%> (ø)
src/methods/extract.jl	78.94% <0.00%> (ø)
src/methods/rasterize.jl	91.81% <0.00%> (ø)
... and 1 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

[rafaqz]

Thanks for tracking all of those down!

The main change is how you are using get on kw - we can just add the source keyword instead directly in the function keyword arguments.

This PR will also need some tests that specify the source type manually.

[rafaqz]

Tests?

[yvikhlya]

Tests?

I have no idea how to write tests, but I I'll look into it.

[rafaqz]

Tests are crucial, more important than the code in the long term. Otherwise I or someone else might break this functionality again by accident.

You can see some other tests in the tes/gdal.jl and test/ncdatasets.jl - that might be a good place to add tests where you rename a file to something custom and then force it to the right file type.

Do your best anyway! If not I can add them.

[yvikhlya]

Can you recommend some good tutorial on writing tests in julia? I feel that I need to make myself more familiar with this anyway.

[rafaqz]

Maybe https://bkamins.github.io/julialang/2022/04/22/testing.html?

or https://itnext.io/organizing-tests-in-julia-c3de1e43d6ab

[yvikhlya]

Ok, making tests turned out to be not so difficult, but I think that they reveal some more bugs. I copy test/data/*.nc files to *.nc4 files and try to create Raster and RasterStack objects from them. First, Raster() works without source=Rasters.NCDfile keyword, and with this keyword throws

ERROR: MethodError: no method matching _open(::Type{Array}, ::Type{Rasters.NCDfile}, ::ArchGDAL.RasterDataset{Float32, ArchGDAL.Dataset}; key=nothing)

This is inconsistent with RasterStack interface. Second, both Raster and RasterStack created from *.nc files are not equal to Raster and RasterStack created from *.nc4 files, they do not pass isequal test. Is such behavior expected?

[rafaqz]

but I think that they reveal some more bugs

Thats great. Can you push the tests so I can try to find your problems?

[yvikhlya]

Not sure if I am doing the right thing, but here is my attempt.