generic constructors like zeros make GeoArrays #221
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #221 +/- ##
==========================================
+ Coverage 80.71% 80.73% +0.01%
==========================================
Files 20 20
Lines 2007 2009 +2
==========================================
+ Hits 1620 1622 +2
Misses 387 387
Continue to review full report at Codecov.
|
|
Haha this does indicate that the design is good |
|
And most of the added code in DD was just |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #216
@mkborregaard this turned out to be super simple with a minor change in rafaqz/DimensionalData.jl#333
falses(dims(A))andtrues/zeros/ones/fill/randwill now make aGeoArrayif theLookupArrayfor any dimension is<: AbstractProjected. Which is every X/Y dim made by GeoData.