Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix heatmap! #551

Merged
merged 9 commits into from
Oct 18, 2023
Merged

Fix heatmap! #551

merged 9 commits into from
Oct 18, 2023

Conversation

felixcremer
Copy link
Contributor

This fixes the heatmap! function in Makie.
This also adds tests for all bang functions for Makie.

I switched to using Makie because I hoped, that this would enable the testing of Makie on CI or is there something to gain by using GLMakie directly?

Closes #546 .

This also switches to using plain Makie. This should enable using Makie testing on CI.
@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #551 (fceb57f) into main (77409f5) will increase coverage by 5.60%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #551      +/-   ##
==========================================
+ Coverage   82.49%   88.09%   +5.60%     
==========================================
  Files          40       40              
  Lines        3324     3326       +2     
==========================================
+ Hits         2742     2930     +188     
+ Misses        582      396     -186     
Files Coverage Δ
ext/DimensionalDataMakie.jl 89.47% <100.00%> (+89.47%) ⬆️

... and 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@rafaqz
Copy link
Owner

rafaqz commented Oct 13, 2023

Thanks!

Unfortunately adding Makie to CI is a huge overhead. Its not actuslly run during CI either.

Maybe its worthwhile?

ext/DimensionalDataMakie.jl Outdated Show resolved Hide resolved
@felixcremer
Copy link
Contributor Author

I now use CairoMakie. That might be a good compromise, so that we don't have to deal wit GL on CI.

The broken tests are things that I would expect to work. The commented test also didnt work for the plain data.

test/plotrecipes.jl Outdated Show resolved Hide resolved
@felixcremer
Copy link
Contributor Author

The failure on nightly is that some of the @test_broken are going through and do not throw an error anymore.

@rafaqz
Copy link
Owner

rafaqz commented Oct 14, 2023

Ok maybe comment them out, we can fix them later

@felixcremer
Copy link
Contributor Author

I now fixed the volume! and volumeslices! functions and commented some tests for series which is basically #552 .

@rafaqz
Copy link
Owner

rafaqz commented Oct 16, 2023

Amazing, thanks. Might be good to leave a TODO comment why those tests are commented.

@felixcremer
Copy link
Contributor Author

I added TODOS to remind us to reenable the tests once the series works on the Makie side as expected.
I also added a comment to #552.

This should be good to go now.

@tomchor
Copy link

tomchor commented Oct 18, 2023

Tests are passing 🎉

Merge and release a patch version?

@rafaqz rafaqz merged commit e948e16 into rafaqz:main Oct 18, 2023
7 checks passed
@felixcremer felixcremer deleted the fc/fix_heatmap! branch October 18, 2023 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

heatmap! broken for DimArray
4 participants