Skip to content

Commit

Permalink
koekeishiya#1475 remove window tags debugging info from window queries
Browse files Browse the repository at this point in the history
  • Loading branch information
koekeishiya committed Oct 20, 2022
1 parent c888d80 commit 8153385
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 8 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ This project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.htm

## [Unreleased]
### Changed
- Fixed issue that could cause yabai to crash during a window query operation under certain conditions when a window closes [#1475](https://github.com/koekeishiya/yabai/issues/1475)
- Remove window tags used for debugging purposes from result of window query because it could cause a crash under certain conditions when a window closes [#1475](https://github.com/koekeishiya/yabai/issues/1475)

## [5.0.1] - 2022-09-26
### Changed
Expand Down
5 changes: 2 additions & 3 deletions doc/yabai.1
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@
.\" Title: yabai
.\" Author: [see the "AUTHOR(S)" section]
.\" Generator: Asciidoctor 2.0.16
.\" Date: 2022-09-23
.\" Date: 2022-10-20
.\" Manual: Yabai Manual
.\" Source: Yabai
.\" Language: English
.\"
.TH "YABAI" "1" "2022-09-23" "Yabai" "Yabai Manual"
.TH "YABAI" "1" "2022-10-20" "Yabai" "Yabai Manual"
.ie \n(.g .ds Aq \(aq
.el .ds Aq '
.ss \n[.ss] 0
Expand Down Expand Up @@ -637,7 +637,6 @@ WINDOW
},
"role": string,
"subrole": string,
"tags": string,
"display": number,
"space": number,
"level": number,
Expand Down
1 change: 0 additions & 1 deletion doc/yabai.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -459,7 +459,6 @@ WINDOW
},
"role": string,
"subrole": string,
"tags": string,
"display": number,
"space": number,
"level": number,
Expand Down
3 changes: 0 additions & 3 deletions src/window.c
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,6 @@ void window_serialize(FILE *rsp, struct window *window)
bool border = window->border.id ? 1 : 0;
float opacity = window_opacity(window);
bool grabbed = window == g_mouse_state.window;
uint64_t tags = window_tags(window);

struct view *view = window_manager_find_managed_window(&g_window_manager, window);
struct window_node *node = view ? view_find_window_node(view, window->id) : NULL;
Expand All @@ -146,7 +145,6 @@ void window_serialize(FILE *rsp, struct window *window)
"\t\"frame\":{\n\t\t\"x\":%.4f,\n\t\t\"y\":%.4f,\n\t\t\"w\":%.4f,\n\t\t\"h\":%.4f\n\t},\n"
"\t\"role\":\"%s\",\n"
"\t\"subrole\":\"%s\",\n"
"\t\"tags\":\"0x%016llx\",\n"
"\t\"display\":%d,\n"
"\t\"space\":%d,\n"
"\t\"level\":%d,\n"
Expand Down Expand Up @@ -177,7 +175,6 @@ void window_serialize(FILE *rsp, struct window *window)
window->frame.origin.x, window->frame.origin.y, window->frame.size.width, window->frame.size.height,
role,
subrole,
tags,
display,
space,
window_level(window),
Expand Down

0 comments on commit 8153385

Please sign in to comment.