koekeishiya#148 only allow window_animation_duration to be set if SIP…

… is partially disabled
rafaelliu · Sep 25, 2022 · 40f900a · 40f900a
1 parent 719af3b
commit 40f900a
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 5 deletions.
diff --git a/src/message.c b/src/message.c
@@ -1146,7 +1146,11 @@ static void handle_domain_config(FILE *rsp, struct token domain, char *message)
  fprintf(rsp, "%f\n", g_window_manager.window_animation_duration);
  } else if (value.type == TOKEN_TYPE_FLOAT) {
  if (CGPreflightScreenCaptureAccess()) {
- g_window_manager.window_animation_duration = value.float_value;
+ if (scripting_addition_is_sip_friendly()) {
+ g_window_manager.window_animation_duration = value.float_value;
+ } else {
+ daemon_fail(rsp, "command '%.*s' for domain '%.*s' requires System Integrity Protection to be partially disabled! ignoring request..\n", command.length, command.text, domain.length, domain.text);
+ }
  } else {
  daemon_fail(rsp, "command '%.*s' for domain '%.*s' requires Screen Recording permissions! ignoring request..\n", command.length, command.text, domain.length, domain.text);
  CGRequestScreenCaptureAccess();

diff --git a/src/sa.m b/src/sa.m
@@ -307,14 +307,10 @@ static bool scripting_addition_is_sip_friendly(void)
  csr_get_active_config(&config);
 
  if (!(config & CSR_ALLOW_UNRESTRICTED_FS)) {
- warn("yabai: System Integrity Protection: Filesystem Protections must be disabled!\n");
- notify("scripting-addition", "System Integrity Protection: Filesystem Protections must be disabled!");
  return false;
  }
 
  if (!(config & CSR_ALLOW_TASK_FOR_PID)) {
- warn("yabai: System Integrity Protection: Debugging Restrictions must be disabled!\n");
- notify("scripting-addition", "System Integrity Protection: Debugging Restrictions must be disabled!");
  return false;
  }
 
@@ -341,6 +337,8 @@ static bool mach_loader_inject_payload(void)
 int scripting_addition_uninstall(void)
 {
  if (!scripting_addition_is_sip_friendly()) {
+ warn("yabai: System Integrity Protection: Filesystem Protections and Debugging Restrictions must be disabled!\n");
+ notify("scripting-addition", "System Integrity Protection: Filesystem Protections and Debugging Restrictions must be disabled!");
  return 1;
  }
 
@@ -368,6 +366,8 @@ int scripting_addition_load(void)
  }
 
  if (!scripting_addition_is_sip_friendly()) {
+ warn("yabai: System Integrity Protection: Filesystem Protections and Debugging Restrictions must be disabled!\n");
+ notify("scripting-addition", "System Integrity Protection: Filesystem Protections and Debugging Restrictions must be disabled!");
  result = 1;
  goto out;
  }