Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*.: complete checksum statement #703 #715

Merged
merged 1 commit into from
Jan 13, 2021

Conversation

hustjieke
Copy link
Contributor

[summary]

  1. add [QUICK | EXTENDED] option.
  2. fix "checksum/drop TABLE ..." ---> "checksum/drop {TABLE | TABLES} ...".
  3. support checksum multi tables.

[test case]
src/planner/others_plan_test.go
src/proxy/checksumtable_test.go

[patch codecov]
src/planner/others_plan.go 91.4%
src/proxy/checksumtable.go 96.9%

[summary]
1. add [QUICK | EXTENDED] option.
2. fix "checksum/drop TABLE ..." ---> "checksum/drop {TABLE | TABLES} ...".
3. support checksum multi tables.

[test case]
src/planner/others_plan_test.go
src/proxy/checksumtable_test.go

[patch codecov]
src/planner/others_plan.go  91.4%
src/proxy/checksumtable.go  96.9%
@codecov
Copy link

codecov bot commented Jan 7, 2021

Codecov Report

Merging #715 (c221a95) into master (3885e5a) will increase coverage by 0%.
The diff coverage is 89%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #715   +/-   ##
=====================================
  Coverage      88%    89%           
=====================================
  Files         131    131           
  Lines        9308   9322   +14     
=====================================
+ Hits         8282   8297   +15     
- Misses        679    680    +1     
+ Partials      347    345    -2     
Impacted Files Coverage Δ
src/planner/others_plan.go 89% <77%> (-4%) ⬇️
src/proxy/checksumtable.go 97% <96%> (+<1%) ⬆️
src/backend/queryz.go 87% <0%> (-4%) ⬇️
src/backend/txn.go 87% <0%> (+<1%) ⬆️
src/backend/xacheck.go 81% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3885e5a...c221a95. Read the comment docs.

@hustjieke hustjieke marked this pull request as ready for review January 11, 2021 02:40
@BohuTANG BohuTANG requested review from andyli029 and removed request for BohuTANG January 12, 2021 00:50
@BohuTANG
Copy link
Contributor

Ping @andyli029 for review

@andyli029
Copy link
Contributor

ACK.

@andyli029
Copy link
Contributor

LGTM

@BohuTANG BohuTANG merged commit 07f42c3 into radondb:master Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants