.*: complete insert/replace statement #708 #709
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
55604fc
to
ddaeebe
Compare
Codecov Report
@@ Coverage Diff @@
## master #709 +/- ##
=====================================
- Coverage 89% 89% -1%
=====================================
Files 131 131
Lines 9284 9308 +24
=====================================
+ Hits 8271 8286 +15
- Misses 672 676 +4
- Partials 341 346 +5
Continue to review full report at Codecov.
|
ddaeebe
to
f8a54e2
Compare
[summary] compute insert/replace statement. 1. add [HIGH_PRIORITY | LOW_PRIORITY | DELAYED] options for Insert, add [LOW_PRIORITY | DELAYED] options for Replace Statement. 2. remove "on duplicate key update" for Replace Statement, this is a bug. 3. add support for "PARTITION" to parse, but the function hasn't implement yet. 4. add support for writing data without columns, like: "insert into t values ...." 5. refactor some code on insert plan. [test case] src/planner/insert_plan_test.go src/proxy/insert_test.go src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parse_test.go [patch codecov] src/planner/insert_plan.go 93.7% src/proxy/insert.go 92.0% src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.6%
f8a54e2
to
5b8db72
Compare
|
This feature is really cool, I need @andyli029 to review it first. |
andyli029
reviewed
Dec 28, 2020
andyli029
reviewed
Dec 28, 2020
[summary] fix wrong word 'globle' --> 'global' [test case] N/A [patch codecov] N/A
|
LGTM |
…sn't match value count' radondb#708 [summary] add fail test cases about insert stmt 'Column count doesn't match value count',e.g.: create table t(a int key); insert /*success test*/ into t values(1); insert /*fail test*/ into t values(2, 3); [test case] N/A [patch codecov] N/A
|
LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[summary]
compute insert/replace statement.
[LOW_PRIORITY | DELAYED] options for Replace Statement.
implement yet.
[test case]
src/planner/insert_plan_test.go
src/proxy/insert_test.go
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/parse_test.go
[patch codecov]
src/planner/insert_plan.go 93.7%
src/proxy/insert.go 87.0%
src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/ast.go 96.6%