Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Collapsible #30

Merged
merged 19 commits into from
Jun 19, 2024
Merged

Feature: Collapsible #30

merged 19 commits into from
Jun 19, 2024

Conversation

mrfrac
Copy link
Collaborator

@mrfrac mrfrac commented Jun 16, 2024

Description

PR to add new feature: collapsible.

PR includes:

  • 2 sb stories
    • normal operating mode (no animation)
    • animation demo (angular animation capabilities)

PR NOT includes at this moment:

  • tests
  • not fully comply with the Radix Collapsible API (verfication required)

want to get feedback and critics!

@mrfrac mrfrac added the enhancement New feature or request label Jun 16, 2024
Copy link

vercel bot commented Jun 16, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
primitives ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 19, 2024 1:17pm

Copy link

vercel bot commented Jun 16, 2024

@mrfrac is attempting to deploy a commit to the Radix-angular Team on Vercel.

A member of the Team first needs to authorize it.

@mrfrac
Copy link
Collaborator Author

mrfrac commented Jun 19, 2024

some additions:

  • fix external triggering capability
  • add SB story for external triggering feature
  • add mdx docs

feel free to comment and feedback here. at this moment my work is finished.

ready for review now

@mrfrac mrfrac marked this pull request as ready for review June 19, 2024 03:56
@mrfrac mrfrac requested a review from pimenovoleg June 19, 2024 03:56
@pimenovoleg pimenovoleg merged commit 41b9364 into radix-ng:main Jun 19, 2024
3 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants