Tags: radiasoft/sirepo
Tags
Fix #6990: Improve NERSC login/error handling (#7055) This fixes a variety of open issues related to NERSC login. Fix #6106: Add a login to sbatch button to the simulation status panel. The login modal will still appear automatically when long is needed but in the event the user closes it the start simulation button is replaced with a login button until they login. Fix #5411: Improved display of sbatch connection errors. Now the errors are displayed within the login panel itself. Not in the stateAsText line and with blue/red text above the start simulation button. We still need to handle better text for when NERSC is down (#7041) Fix #4625: Same as #5411. Fix #7054: Check the computeJobSerial when handling responses from simulationFrame and only update the gui if the current computeJobSerial is the same as the one that was current when the requests were sent. Fix #4367: Also fixed by #7054. There are multiple paths through the code to handle. They are hard to test in an automated fashion so I've described them below: **no data happy path**: - no existing data - user selects vagrant cluster - show login button - click login button - enter creds - agent starts - show start simulation button **no data wrong creds**: - no existing data - user select vagrant cluster - show login button - enter bad creds - see message - retry - repeat until creds are good - agent starts - show start simulation button **no data cannot connect**: - no existing data - user selects vagrant - show login button - enter creds - Get message about unable to connect - they can try again or leave modal - if they close modal the login button is presented again **no data close modal** - no existing data - user selects vagrant - click login button - user closes modal - we stay on the page showing the login button **existing simulation frames happy path** - user has a simulation with frames - agent is dead - they go to the page with the report - modal appears requesting login creds - enter creds (handling bad creds / cannot connect) - panel refreshes displaying the data **existing simulation frames close modal**: - user has a simulation with existing frames - agent is dead - they go to the page with the report - modal appears requesting login creds - they close the modal (not entering creds) - panel has an alert telling them they need to log in - login button is present in panel **existing simulation frames, close modal, click login button**: - user has a simulation with existing frames - agent is dead - they go to the page with the report - modal appears requesting login creds - hey close the modal (not entering creds) - panel has an alert telling them they need to log in and the button to log in is present - they click the login button and log in - frames are retreived automatically **gui already thinks user is logged in (showing start sim button instead of login button) but agent is dead (not logged in) happy path**: - user clicks start simulation - modal to log in is presented - they enter their credentials - if they enter invalid creds then they are presented with a warning in the login modal and a chance to re-enter creds - repeat until creds are valid - new simulation is started for them automatically **gui already thinks user is logged in (showing start sim button instead of login button) but agent is dead (not logged in) close modal path**: - user clicks start simulation - modal to log in is presented - they close the modal w/o providing valid creds - simulationStatusPanel shows job state missing with no data - button to log in is present
Fix #7074: impactt app (#7081) Co-authored-by: Paul Moeller <[email protected]>
PreviousNext