various fixes: build on Linux etc. #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Filenames are case-sensitive
My editor does this automatically, so I end up with lots of noisy diffs if this isn't done in advance.
This prevents wrapping the display incorrectly.
Having a space in case the temperature or humidity is less than 3 digits makes it easier to read.
…P string functions to be used here
Adding PSTR macro to jsonKeyFind() call needs _P string functions to be used here
Add whitespaces because of compiler warnings
This makes the code a little smaller. If I build with avr-gcc 4.8.2 on Ubuntu, it otherwise ends up just a little too large to fit in flash.
I want to add a ring buffer but memory is tight.
even more PSTR; bit packing of some variables
…type A switch statement might take memory if the compiler generates a jump table: http:https://thegaragelab.com/conserving-memory-on-an-avr/ (although it seems to me that it doesn't, with avr-gcc 4.8, at least). The tube type will not change at runtime; we only need a multiplier constant, and the name as a string for concatenation. The compiler can do string concatenation too, so there's no reason to use printf("tube %s") to substitute a string which will never change. This change saves 30 bytes of RAM.
For this we need a ring buffer to remember at least a few samples. If we want to have a line graph later, we'll need to remember even more. But more urgently the idea is to find the outliers, which requires comparing against the mean... this isn't done yet.
cpmMin, cpmMax, cpmAverage
|
I had the same problem with the network module being offline, when I first tried to compile the firmware on a Windows machine. You'll need to use at least sw version 123 to get something valid and working compiled. I couldn't be bothered to find out what the problem behind that was, though. |
We'll soon need other buffers storing other types.
This makes possible logging in the field with an Adalogger or some such.
My memory sucks; if I hadn't left the programmer attached to the device, I'd have forgotten how to connect it for programming, and that I even had a 3.3V programmer in the first place, and what kind.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fixes should be OK to merge I think. However there's still something wrong with the usage of the network module: it's basically offline and resetting periodically (due to a watchdog?) So, not sure if I'm still missing something in the Makefile which is necessary to get that working.