Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RN code snippets to trips tracking page #446

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

KennyHuRadar
Copy link
Contributor

@KennyHuRadar KennyHuRadar commented Feb 28, 2024

What?

Adding code snippets for RN within the trip tracking Doc in line with our vision of making RN a "first class citizen" .

Why?

How?

Screenshots (optional)

Anything Else? (optional)

Copy link

vercel bot commented Feb 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
documentation ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 29, 2024 9:43pm

@KennyHuRadar KennyHuRadar changed the title add react native code snippets to trips tracking page Add react native code snippets to trips tracking page Feb 28, 2024
@KennyHuRadar KennyHuRadar changed the title Add react native code snippets to trips tracking page Add RN code snippets to trips tracking page Feb 28, 2024
@KennyHuRadar KennyHuRadar marked this pull request as ready for review February 28, 2024 20:37
Copy link
Contributor

@lmeier lmeier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

few changes


```javascript
Radar.startTrip({
tripOptions:{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between : and {

CarMode: "Green Honda Civic"
}
},
trackingOptions:{ ... }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space between : and {

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also we should make it clear how to easily track with tracking options based off a preset (we discussed this in person)

},
trackingOptions:{ ... }
}).then((result)=>{
if(result.status == 'SUCCESS'){
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing spacing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants