Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Missing Exports and Imports on ELF #17001

Merged
merged 2 commits into from Jun 7, 2020
Merged

Fix Missing Exports and Imports on ELF #17001

merged 2 commits into from Jun 7, 2020

Conversation

ghost
Copy link

@ghost ghost commented Jun 2, 2020

Your checklist for this pull request

  • I've read the guidelines for contributing to this repository
  • I made sure to follow the project's coding style
  • I've added tests that prove my fix is effective or that my feature works (if possible)
  • I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description
Work on #12732
See #12061

PS: i will add one regression test (i just need to push libarm64.so)
radareorg/radare2-testbins#24

Test plan
r2 libarm64.so
2020-06-02-174831_558x501_scrot

Closing issues
#12061

@ghost ghost requested review from kazarmy and ret2libc as code owners June 2, 2020 15:50
@ret2libc ret2libc self-assigned this Jun 3, 2020
@ghost
Copy link
Author

ghost commented Jun 3, 2020

@ret2libc there is a bug with the appveyor status again.

Copy link
Contributor

@ret2libc ret2libc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a test for libarm64.so, but the change looks fine to me! Thanks!

@ghost ghost requested a review from radare as a code owner June 4, 2020 15:32
@ghost
Copy link
Author

ghost commented Jun 4, 2020

Please add a test for libarm64.so, but the change looks fine to me! Thanks!

done

Ps: there seems that the openbsd.yml weebhook failed

@XVilka XVilka merged commit 77e9059 into radareorg:master Jun 7, 2020
@ghost ghost deleted the fix_missing_exports_and_imports_on_elf branch June 8, 2020 13:56
Emi1305 pushed a commit to Emi1305/radare2 that referenced this pull request Jul 12, 2020
* Remove the offset check
* Add regression test for the invalid offset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants