Unify the relocations loading

[ghost]

Your checklist for this pull request

• I've read the guidelines for contributing to this repository
• I made sure to follow the project's coding style
• I've added tests that prove my fix is effective or that my feature works (if possible)
• I've updated the documentation and the radare2 book with the relevant information (if needed)

Detailed description
The relocations are loaded 3 times... I try to fix that.

Test plan
...

Closing issues
#12732
...

[ghost]

@ret2libc Again i move stuff up... sorry
I was thinking about using Ht_(foreach) on rel_cache when used inside bin_elf.inc?

  2 libr/bin/p/bin_elf.inc
  3 691:            if (!(relocs = Elf_(r_bin_elf_get_relocs) (bin))) {
  4 907:    if (!(relcs = Elf_(r_bin_elf_get_relocs) (bin))) {

Is this function well optimized?

[ret2libc]

Is this function well optimized?

I guess that depends on what you mean by "well optimized" :) It is a foreach, it iterates over each element of the hash table and run a callback function. You can use that to convert the hashtable to an array. It will be O(n) and that is what matters for now I think. If we need even more optimization, we can take care of that later if/when needed.

[ghost]

An other alternative could be

bin->relocs (array relocs)
bin->rel_cache (Hash Table)

[ghost]

In the idea bin->relocs would hold all the data and rel_cache reference the array

[ghost]

@ret2libc For me this refactorization is done

[ret2libc]

IMHO it's better to keep using Elf_(r_bin_elf_get_relocs) to access relocations. Inside that function, you can fill bin->relocs and bin->rel_cache the first time and then return bin->relocs once it was set.

[ghost]

I removed a check for bin->g_section because all the subfunctions do already the check.

[ret2libc]

Thanks! LGTM