Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disassembly highlighting for complex DSP instructions #437

Open
XVilka opened this issue Dec 7, 2013 · 15 comments
Open

Fix disassembly highlighting for complex DSP instructions #437

XVilka opened this issue Dec 7, 2013 · 15 comments

Comments

@XVilka
Copy link
Contributor

XVilka commented Dec 7, 2013

For instructions like:

mov *(ar1+t0b) << t3, ac2 || mov ac1.l , *ar4

currently determined "mov ac1.l, *ar4" instruction as part of "ac2" operand

rptblocal #0x000011 || sfts ac0,  #-1

currently determined "sfts" as part of 0x000011 number

cmp t2 == t3, tc1

currently determined "t2 ==" as part of instruction keyword "cmp"

xccpart ac0 <=  #0 || mov #0x0, t0

currently determined "ac0" as part of "xccpart" instruction keyword, "|| mov #0x0, t0" as part of number #0

Proof:
rarjpeg

@XVilka XVilka added the blocker label Feb 6, 2014
@XVilka
Copy link
Contributor Author

XVilka commented Apr 19, 2014

@milabs - thats for you :)

@milabs
Copy link
Contributor

milabs commented Apr 21, 2014

@XVilka Perfect! Didn't understand nothing :)

@XVilka
Copy link
Contributor Author

XVilka commented Jun 25, 2014

@milabs - can you please try to fix this before 0.9.8 release (two weeks from now)?

@radare
Copy link
Collaborator

radare commented Jun 25, 2014

There are some warnings that should be addressed too. The 'colors' depend on the op->type. Also, adding support for ESIL would be great

@milabs
Copy link
Contributor

milabs commented Jul 12, 2014

@XVilka I'll try to do it tomorrow

@XVilka
Copy link
Contributor Author

XVilka commented Jul 29, 2014

@milabs it is in https://github.com/radare/radare2/blob/master/libr/core/disasm.c function
handle_build_op_str (RCore *core, RDisasmState *ds)

@radare
Copy link
Collaborator

radare commented Aug 5, 2014

Thanks @milabs

@radare radare closed this as completed Aug 5, 2014
@XVilka
Copy link
Contributor Author

XVilka commented Aug 5, 2014

@milabs
Fixed, but still not completely - check the new screen:
c55x+ highlighting

@XVilka XVilka reopened this Aug 5, 2014
@jvoisin
Copy link
Contributor

jvoisin commented Aug 14, 2014

This is related to #1195

@XVilka XVilka modified the milestones: 0.9.8, 0.9.9 Aug 22, 2014
@radare radare closed this as completed Aug 22, 2014
@radare radare reopened this Aug 22, 2014
@radare radare modified the milestones: 1.0.0, 0.9.9 Apr 18, 2015
@radare
Copy link
Collaborator

radare commented Apr 22, 2015

ping

@XVilka
Copy link
Contributor Author

XVilka commented Apr 22, 2015

@radare postpone this for 1.0.0 - it will require a huge refactoring of the highlighting code

@radare
Copy link
Collaborator

radare commented Sep 27, 2016

ping ? 1.0 is close, is anyone up for this? because imho its quite low prio and i'll put it for 9999

@radare
Copy link
Collaborator

radare commented Oct 27, 2016

i assume nobody is gonna do anything related to this in two weeks after waiting 3 years

@radare radare modified the milestones: 9999, 1.0.0 Oct 27, 2016
@XVilka
Copy link
Contributor Author

XVilka commented Jul 24, 2018

Applies also on Hexagon (note that in lines R2 = 0x21 ; R1:R0 = combine (#0, R23) and R2 = 0x21 ; memw (Sp + 0x24) = R4 highlighting is wrong)
screenshot_20180724_112435
screenshot_20180724_112507

@XVilka XVilka added this to To do in Console Interface Improvements via automation Apr 3, 2019
yossizap pushed a commit to yossizap/radare2 that referenced this issue Dec 30, 2019
@ret2libc
Copy link
Contributor

@XVilka still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

6 participants