-
-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix disassembly highlighting for complex DSP instructions #437
Comments
@milabs - thats for you :) |
@XVilka Perfect! Didn't understand nothing :) |
@milabs - can you please try to fix this before 0.9.8 release (two weeks from now)? |
There are some warnings that should be addressed too. The 'colors' depend on the op->type. Also, adding support for ESIL would be great |
@XVilka I'll try to do it tomorrow |
@milabs it is in https://github.com/radare/radare2/blob/master/libr/core/disasm.c function |
Thanks @milabs |
@milabs |
This is related to #1195 |
ping |
@radare postpone this for 1.0.0 - it will require a huge refactoring of the highlighting code |
ping ? 1.0 is close, is anyone up for this? because imho its quite low prio and i'll put it for 9999 |
i assume nobody is gonna do anything related to this in two weeks after waiting 3 years |
@XVilka still relevant? |
For instructions like:
currently determined "mov ac1.l, *ar4" instruction as part of "ac2" operand
currently determined "sfts" as part of 0x000011 number
currently determined "t2 ==" as part of instruction keyword "cmp"
currently determined "ac0" as part of "xccpart" instruction keyword, "|| mov #0x0, t0" as part of number #0
Proof:
![rarjpeg](https://camo.githubusercontent.com/8bb0afac06389f41542f818f06806c47d3845b4d587aea1518f7efa19e795dda/687474703a2f2f7876696c6b612e6d652f72322d6473702d686967682e706e67)
The text was updated successfully, but these errors were encountered: