Refactor notifications checks in tests

[santib]

• Unify how notifications are tracked and checked using Array's #push #pop and #size.
• With this now we not only check "some notification happened" but the exact amount of notifications since in some cases we might trigger more than once, so this can prevent missing or mixing notifications.

Note: We could introduce a custom class built on top of Array with some facilities but seems to not be worth it at the time

[grzuy]

Good call.
Neat.

Maybe adding some array emptying on after each test hook?
Just not to rely only on each test poping?
Minor thing, your call.

[santib]

Good call. Neat.

Maybe adding some array emptying on after each test hook? Just not to rely only on each test poping? Minor thing, your call.

Thanks for the review 😊 I think the emptying isn’t needed because the array gets recreated for each test. Or am I missing something?

[grzuy]

Good call. Neat.
Maybe adding some array emptying on after each test hook? Just not to rely only on each test poping? Minor thing, your call.

Thanks for the review 😊 I think the emptying isn’t needed because the array gets recreated for each test. Or am I missing something?

Right, hehe.
My bad.