-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new Armstrong number tests #2
Conversation
Added several new test cases for Armstrong numbers to the exercism API tests suite. This includes checks for a seven digit Armstrong number, error scenarios when number is not specified, a seven digit number that's not Armstrong, and when there are no two digit Armstrong numbers. This will enhance the test coverage and ensure the robustness of the API.
Warning Rate Limit Exceeded@rabestro has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 2 minutes and 1 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe updates primarily enhance the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (6)
- exercism-api-tests/Armstrong Numbers/A seven digit number that is an Armstrong number.bru (1 hunks)
- exercism-api-tests/Armstrong Numbers/A seven digit number that is not an Armstrong number.bru (1 hunks)
- exercism-api-tests/Armstrong Numbers/Error when number is not specified.bru (1 hunks)
- exercism-api-tests/Armstrong Numbers/Single digits are Armstrong numbers.bru (1 hunks)
- exercism-api-tests/Armstrong Numbers/There are no two digit Armstrong numbers.bru (1 hunks)
- exercism-api-tests/Armstrong Numbers/Zero is Armstrong numbers.bru (1 hunks)
Files skipped from review due to trivial changes (1)
- exercism-api-tests/Armstrong Numbers/Zero is Armstrong numbers.bru
Additional Context Used
Additional comments not posted (3)
exercism-api-tests/Armstrong Numbers/There are no two digit Armstrong numbers.bru (1)
18-18
: The assertionisFalsy
is correctly used to verify that there are no two-digit Armstrong numbers, specifically testing the number 10. This test case is well-structured and follows the expected format for HTTP tests.exercism-api-tests/Armstrong Numbers/Error when number is not specified.bru (1)
14-17
: The assertions for checking a 400 status code and the presence of an error message containing "pass a number" are correctly implemented. This test case appropriately enhances the API's error handling capabilities for requests without a specified number.exercism-api-tests/Armstrong Numbers/A seven digit number that is an Armstrong number.bru (1)
18-18
: The assertionisTruthy
is correctly used to verify that the number 9926315 is an Armstrong number. This test case is well-structured and follows the expected format for HTTP tests.
exercism-api-tests/Armstrong Numbers/A seven digit number that is not an Armstrong number.bru
Outdated
Show resolved
Hide resolved
exercism-api-tests/Armstrong Numbers/A seven digit number that is not an Armstrong number.bru
Outdated
Show resolved
Hide resolved
… is not an Armstrong number.bru Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
… is not an Armstrong number.bru Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Status
Configuration used: CodeRabbit UI
Files selected for processing (1)
- exercism-api-tests/Armstrong Numbers/A seven digit number that is not an Armstrong number.bru (1 hunks)
Files skipped from review as they are similar to previous changes (1)
- exercism-api-tests/Armstrong Numbers/A seven digit number that is not an Armstrong number.bru
Added several new test cases for Armstrong numbers to the exercism API tests suite. This includes checks for a seven digit Armstrong number, error scenarios when number is not specified, a seven digit number that's not Armstrong, and when there are no two digit Armstrong numbers. This will enhance the test coverage and ensure the robustness of the API.
Summary by CodeRabbit