ra_SUITE: Fix flake in consistent_query_leader_change #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The line:
{ok, 9, B} = ra:consistent_query(B, fun(S) -> S end),
would flake because `B` might fail to become the leader.
`ra:transfer_leadership/2` is asynchronous and fallible and in cases
where the test flaked, `B` was recovering and catching up to the latest
changes, so it didn't assume leadership.
We can wait for `B` to catch up enough that it should win pre-votes and
then wait for it to assume leadership before asserting that `B` is the
leader to fix the flake.
michaelklishin
deleted the
md-flake-ra_SUITE-consistent_query_leader_change
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The line:
{ok, 9, B} = ra:consistent_query(B, fun(S) -> S end)would flake because
Bmight fail to become the leader.ra:transfer_leadership/2is asynchronous and fallible and in cases where the test flaked,Bwas recovering and catching up to the latest changes, so it didn't assume leadership.We can wait for
Bto catch up enough that it should win pre-votes and then wait for it to assume leadership before asserting thatBis the leader to fix the flake.