-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add_samplet: feature_names allows dimension mismatch, order isn't paired -- will overwrite #45
Comments
Thanks a lot Will for putting pyradigm to test and reporting these bugs! Let me look into them and see why they that happened. but these bugs hopefully haven't prevented you from running comparisons? I am zoom and we can discuss this more if you want -- and to prepare for the "progress report" so to say. |
WillForan
added a commit
to WillForan/pyradigm
that referenced
this issue
Dec 11, 2020
Currently throws out anything that doesn't exactly match previous feature names. A better solution might be to reorder features if features_names are out of order. Also could make np.nan in features if feature_names are missing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
I had a few bugs (using wrong variable name), and realized I never got yelled at for providing bad feature names.
A few observations:
there can be too many (x, y, z and an additional "DNE" name)
or too few (only x, but have x, y, and z)
this is a potentially surprising when features given to
add_samplet
in a different order -- even iffeature
andfeature_names
are paired correctly (@raamana -- a thing you warned me to check. good eye!)The text was updated successfully, but these errors were encountered: