Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.3.0 #4

Merged
merged 7 commits into from
Aug 10, 2018
Merged

v0.3.0 #4

merged 7 commits into from
Aug 10, 2018

Conversation

ra1028
Copy link
Owner

@ra1028 ra1028 commented Aug 10, 2018

Version 0.3.0

Breaking changes

  • Differentiable.differenceIdentifier is now renamed to identifier.
  • Differentiable.isUpdated(from:) is now meaning reversed, name has become isContentEqual(to:).

@ra1028 ra1028 merged commit 7ab94c3 into master Aug 10, 2018
@ra1028 ra1028 deleted the v0.3.0 branch August 10, 2018 16:40
@Sameesunkaria
Copy link
Contributor

Hi @ra1028 ! 👋🏻

Really loving the work you have done to bring DifferenceKit to life. I just have one concern with this update; identifier is a very generic name for a property, and is often used in many code bases. This makes it so that we would have to rename our previously existing property to conform to Differentiable, if we did not want to use the old identifier as a difference identifier.

I believe that differenceIdentifier was a nicer name for the property, and helps the reader easily understand that it is being used for diffing calculations.

@insidegui
Copy link
Contributor

I have the same concern as @Sameesunkaria

@ra1028
Copy link
Owner Author

ra1028 commented Aug 12, 2018

@Sameesunkaria @insidegui
Oh, agreed 👍
I'll turn back the name of identifier to differenceIdentifier in next release.

@ra1028
Copy link
Owner Author

ra1028 commented Aug 12, 2018

@Sameesunkaria @insidegui
I released it in new version 0.4.0 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants