Properly encode URI component.

r2d32 · Aug 1, 2012 · 138cc38 · 138cc38
1 parent 823559a
commit 138cc38
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/_includes/templates/header._ b/_includes/templates/header._
@@ -19,7 +19,7 @@
   <% if (window.authenticated) { %>
     <%= app.username %> <a class="logout" href="#">Logout</a>
   <% } else { %>
-      <a class="button" href="https://github.com/login/oauth/authorize?client_id={{site.oauth_client_id}}&scope=repo,user,gist&redirect_uri=<%= window.location.href %>">Sign in using Github</a>
+      <a class="button" href="https://github.com/login/oauth/authorize?client_id={{site.oauth_client_id}}&scope=repo,user,gist&redirect_uri=<%= encodeURIComponent(window.location.href) %>">Sign in using Github</a>
   <% } %>
   </div>
   <% if (state.file) { %>

diff --git a/_includes/templates/notification._ b/_includes/templates/notification._
@@ -2,7 +2,7 @@
   <div class="notification <%= type %>">
     Please login with your GitHub account to access that project.
   </div>
-  <a class="button" href="https://github.com/login/oauth/authorize?client_id={{site.oauth_client_id}}&scope=repo, user&redirect_uri=<%= window.location.href %>">Sign in</a>
+  <a class="button" href="https://github.com/login/oauth/authorize?client_id={{site.oauth_client_id}}&scope=repo, user&redirect_uri=<%= encodeURIComponent(window.location.href) %>">Sign in</a>
 <% } else { %>
   <div class="notification <%= type %>">
     <%= message%>