Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

I18n compatible exception emission (Issue #8) #11

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

747
Copy link

@747 747 commented Aug 20, 2021

To throw when the translation is missing instead of raise, that can be catched by I18n::Base.

To `throw` when the translation is missing instead of `raise`, that can be `catch`ed by `I18n::Base`.
@AlexWayfer
Copy link
Contributor

  1. There are no changed or added specs.
  2. You can use rescue instead of catch, what the problem?

@747
Copy link
Author

747 commented Feb 24, 2022

@AlexWayfer

  1. There are no changed or added specs.

Will look into it.

  1. You can use rescue instead of catch, what the problem?

My memory is starting to blur after a while, but IIRC this is not whether I rescue or not, but I18n, that calls this as a backend, responds to the exception on its part and then malfunctions. Have you tried out my test package on the other issue #8? Hope you have time to check if it is not my misconception.

@AlexWayfer
Copy link
Contributor

My memory is starting to blur after a while, but IIRC this is not whether I rescue or not, but I18n, that calls this as a backend, responds to the exception on its part and then malfunctions. Have you tried out my test package on the other issue #8? Hope you have time to check if it is not my misconception.

With existing specs it'd be easier to check different implementations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants