Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

issue #60: adjustcolor alpha.f has no effect on svglite output #62

Closed
wants to merge 3 commits into from

Conversation

nathanwebb
Copy link

Added in the alpha channel information to is_black(). It was only checking the red/green/blue channels, so any black with alpha was being treated as pure black.

@codecov-io
Copy link

Current coverage is 93.77%

Merging #62 into master will not affect coverage as of 1248eb7

@@            master     #62   diff @@
======================================
  Files            6       6       
  Stmts          466     466       
  Branches         0       0       
  Methods          0       0       
======================================
  Hit            437     437       
  Partial          0       0       
  Missed          29      29       

Review entire Coverage Diff as of 1248eb7

Powered by Codecov. Updated on successful CI builds.

@nathanwebb nathanwebb closed this Mar 15, 2016
@nathanwebb nathanwebb reopened this Mar 15, 2016
@hadley
Copy link
Member

hadley commented Mar 22, 2016

Can you please provide a unit test?

@nathanwebb
Copy link
Author

@hadley I've included a failing unit test for the case where colour is black with alpha of 0.5. This is addressed in PR #63. Is this right, or would you prefer me to remove that so that all tests pass?

@nathanwebb
Copy link
Author

@hadley Have you been able to look at this PR? Do you want me to remove the failing test (which is covered by PR #63)?

@hadley hadley closed this in 7e5dc41 Aug 15, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants