Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix resolving the exposed check-dir for the artifact upload #595

Conversation

riccardoporreca
Copy link
Contributor

See #593 (comment) and run https://github.com/riccardoporreca/actions/runs/7679961505?check_suite_focus=true#step:6:174 for the reproduced issue

Error: Input required and not supplied: path

See the same case fixed when using proposed fix from the branch in https://github.com/riccardoporreca/actions/runs/7680406669?check_suite_focus=true#step:6:164

Run actions/upload-artifact@main
with:
name: Linux-rrelease-results
path: non-default-dir
if-no-files-found: warn

* Given the R-expression-nature of `inputs.check-dir`, we still rely on a step output defined from within R but just uses the expression.
* We need to define the output before running the checks to fix r-lib#593 (introduced by r-lib#560) in case of check failures.
@codecov-commenter
Copy link

Codecov Report

Merging #595 (2dbc0b3) into v2-branch (3c89c7f) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           v2-branch      #595   +/-   ##
===========================================
  Coverage     100.00%   100.00%           
===========================================
  Files              2         2           
  Lines             10        10           
===========================================
  Hits              10        10           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@gaborcsardi gaborcsardi merged commit 43e2714 into r-lib:v2-branch Aug 5, 2022
@gaborcsardi
Copy link
Member

Thanks!

@gaborcsardi
Copy link
Member

Now deployed in @v2

@github-actions
Copy link

github-actions bot commented Nov 4, 2022

This pull request has been automatically locked. If you believe you have found a related problem, please file a new issue and include a link to this pull request.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 4, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error from actions/upload-artifact
3 participants