Prevent gpg signing of commits (fixes #30) #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using git 2.x and the `commit.gpgsign` option is enabled, each commit is automatically signed with gpg. As noted by @johnp this usally means that the user has to enter a password, or unlock the gpg key using some other method. This is a problem when having to leave the building because of fire. This commit solves the problem by adding the --no-gpg-sign flag to the `git commit` invocation if the git version being used starts with a "2". This is achieved by checking the output of `git version` and using grep to match the version number.
|
/cc @johnp this implements your suggestion |
glensc
reviewed
Aug 27, 2017
git-fire
Outdated
| @@ -42,7 +42,14 @@ fire() { | |||
| message="$*" | |||
| fi | |||
|
|
|||
| git commit -m "$message" --no-verify | |||
| # for git >= 2.x add the --no-gpg-sign flag | |||
| if (git version | grep \\s2\.) then | |||
There was a problem hiding this comment.
subshell is not necessary, but need ; before then then.
When checking that the git version is 2.x, do not use a subshell and redirect output to /dev/null.
|
I have updated the pull request after a comment from @glensc. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using git 2.x and the
commit.gpgsignoption is enabled, each commit is automatically signed with gpg. As noted in #30 this usually means that the user has to enter a password, or unlock the gpg key using some other method. This is a problem when having to leave the building because of fire.This commit solves the problem by adding the --no-gpg-sign flag to the
git commitinvocation if the git version being used starts with a "2". This is achieved by checking the output ofgit versionand using grep to match the version number.