fix: SeriesInstanceUID fix (compatibility with other software) #96
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hjmjohnson
reviewed
Dec 6, 2023
| @@ -80,7 +80,7 @@ def add_study_and_series_information(ds: FileDataset, series_data): | |||
| ds.StudyDescription = getattr(reference_ds, "StudyDescription", "") | |||
| ds.SeriesDescription = getattr(reference_ds, "SeriesDescription", "") | |||
| ds.StudyInstanceUID = reference_ds.StudyInstanceUID | |||
| ds.SeriesInstanceUID = generate_uid() # TODO: find out if random generation is ok | |||
| ds.SeriesInstanceUID = reference_ds.SeriesInstanceUID | |||
There was a problem hiding this comment.
I believe your solution here is correct. The new images should be part of the previous study.
There was a problem hiding this comment.
@hjmjohnson Thanks for having a look at this! Would you mind reviewing this so it can be merged in a later release?
|
When will this be merged? |
hjmjohnson
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there!
Thank you for providing
rt_utilsto ease the burden of constructing DICOM compliant RTSTRUCTs.We have used your work for research purposes and discovered that generating a random SeriesInstanceUID occasionally breaks functionality in other clinical software (such as RayStation ). So far we have not yet found any problems with the proposed change.
Kind regards