Parameter to reduce the error to a warning #63 #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asim-shrestha
suggested changes
Jan 6, 2023
rt_utils/rtstruct_builder.py
Outdated
Comment on lines
84
to
90
| f"Loaded RTStruct references image(s) that are not contained in input series data. " | ||
| + f"Problematic image has SOP Instance Id: {contour_image.ReferencedSOPInstanceUID}" | ||
| ) | ||
| else: | ||
| raise Exception( | ||
| f"Loaded RTStruct references image(s) that are not contained in input series data. " | ||
| + f"Problematic image has SOP Instance Id: {contour_image.ReferencedSOPInstanceUID}" |
There was a problem hiding this comment.
Lets extract the message in a common variable and reuse within the two cases
There was a problem hiding this comment.
Absolutely! Done here 41aa821
Change the Exception to a warning message if warn_only is set to True
asim-shrestha
approved these changes
Jan 6, 2023
asim-shrestha
suggested changes
Jan 6, 2023
rt_utils/rtstruct.py
Outdated
| @@ -12,9 +12,10 @@ class RTStruct: | |||
| Wrapper class to facilitate appending and extracting ROI's within an RTStruct | |||
| """ | |||
|
|
|||
| def __init__(self, series_data, ds: FileDataset, ROIGenerationAlgorithm=0): | |||
| def __init__(self, series_data, ds: FileDataset, ROIGenerationAlgorithm=0, warn_only: bool = False): | |||
There was a problem hiding this comment.
Same thing as other comment, do we need this?
There was a problem hiding this comment.
Same as above 7798fde
asim-shrestha
suggested changes
Jan 7, 2023
rt_utils/rtstruct_builder.py
Outdated
| @@ -20,18 +20,18 @@ def create_new(dicom_series_path: str) -> RTStruct: | |||
|
|
|||
| series_data = image_helper.load_sorted_image_series(dicom_series_path) | |||
| ds = ds_helper.create_rtstruct_dataset(series_data) | |||
| return RTStruct(series_data, ds) | |||
| return RTStruct(series_data, ds, warn_only=warn_only) | |||
There was a problem hiding this comment.
Lets remove warn_only here (causing build failures)
Try running pytest in the root directory to see if failures persist
There was a problem hiding this comment.
Done, pytest ran with no error
asim-shrestha
approved these changes
Jan 8, 2023
asim-shrestha
pushed a commit
that referenced
this pull request
Jan 8, 2023
asim-shrestha
pushed a commit
that referenced
this pull request
Jan 8, 2023
|
Thanks for making all of the changes! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for issue #63