Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: change uid #15

Merged
merged 7 commits into from
Mar 24, 2021
Merged

feat: change uid #15

merged 7 commits into from
Mar 24, 2021

Conversation

asim-shrestha
Copy link
Contributor

fixes #14

@asim-shrestha
Copy link
Contributor Author

Alternatively, could add a different number than 1 to the root uid to get something more unique.

PYDICOM_IMPLEMENTATION_UID is just PYDICOM_ROOT_UID with a 1 added
image

@awtkns
Copy link
Contributor

awtkns commented Mar 23, 2021

@carluri Should we be using Pydicom's implementation UID or should we be making a new Implementation UID for rt-utils

awtkns
awtkns reviewed Mar 23, 2021
View reviewed changes
rt_utils/utils.py Outdated Show resolved Hide resolved
@awtkns
Copy link
Contributor

awtkns commented Mar 24, 2021

@asim-shrestha Good to merge?

@awtkns awtkns merged commit c9c7dbd into main Mar 24, 2021
@asim-shrestha asim-shrestha deleted the 14-fix-implementationClassUID branch August 26, 2021 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@awtkns awtkns awtkns left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ImplementationClassUID invalid
2 participants
@asim-shrestha @awtkns