Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ImplementationClassUID invalid #14

Closed
leokolezhuk opened this issue Mar 22, 2021 · 2 comments · Fixed by #15
Closed

ImplementationClassUID invalid #14

leokolezhuk opened this issue Mar 22, 2021 · 2 comments · Fixed by #15
Assignees
Labels
bug Something isn't working

Comments

@leokolezhuk
Copy link

The ImplementationClassUID (0002, 0012) tag is set to an invalid value.

In this line it is set to PYDICOM_ROOT_UID value defined in pydicom.
This value is just the root of the pydicom's implementation UID and not the full UID("1.2.826.0.1.3680043.8.498."). The full implementation class UID of pydicom is defined in PYDICOM_IMPLEMENTATION_UID ( "1.2.826.0.1.3680043.8.498.1")

Found out that it is invalid while running the DICOM validation tool dciovfy.

@awtkns awtkns added the bug Something isn't working label Mar 23, 2021
@awtkns
Copy link
Contributor

awtkns commented Mar 23, 2021

HI @leokolezhuk thanks for bringing this to our attention. We have been also considering creating a custom implementation UID for RT-Utils

@leokolezhuk
Copy link
Author

Thanks a lot for a fast response.
Nice library you are making!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants