Fixes and improvements around drag-n-drop #891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First off, that allows to create it with the matching extension (not used yet but will be); second, it's more robust and doesn't keep a temporary file open whenever Quaternion runs even if no attaching ever occurs.
They were used to make drag-n-drop work on the timeline area - unfortunately the respective DropArea in the QML code was, uh, dropped from the code accidentally, just before 0.0.95 was released. This functionality will be reinstated in 0.0.97 in a more unified way - these functions effectively duplicated what ChatRoomWidget was already doing for drag-n-drop on the message input area.
We don't really need to store both the file name and a pointer to the file; just a pointer to the file would do if non-temporary files are treated as, well, files, not paths.
To maintain semblance of sanity in the preprocessed HTML.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #835. Also fixes problems with drag-n-drop of certain HTML, e.g. from LibreOffice.