TimelineTextEditSelector: fix selection extension #852
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KitsuneRal
approved these changes
Feb 27, 2023
KitsuneRal
requested changes
Feb 27, 2023
There was a problem hiding this comment.
Sorry, I was too hasty with the previous review. Actually, this method is defined in ChatRoomWidget but wasn't brought to the right class when TimelineWidget was factored out of ChatRoomWidget. So would you mind deleting ChatRoomWidget::getModifierKeys(), while we're at it?
Extension of current selection by shift+click was broken due to this method wasn't brought to the right class when `TimelineWidget` was factored out of `ChatRoomWidget`.
f6b31dd
to
acd4af3
Compare
KitsuneRal
approved these changes
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extension of current selection by shift+click was broken due to
this method wasn't brought to the right class when
TimelineWidgetwas factored out of
ChatRoomWidget.Error message:
qrc:/qml/TimelineTextEditSelector.qml:23: TypeError: Property 'getModifierKeys' of object TimelineWidget(0x24026c0) is not a function