Show reactions #655
Merged
Show reactions #655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is more flexible than stuffing them into AnnotationRole.
This change does not belong to the reaction branch.
KitsuneRal
requested changes
Apr 8, 2020
client/chatroomwidget.cpp
Outdated
| m_currentRoom->relatedEvents(eventId, EventRelation::Annotation()); | ||
|
|
||
| for (const auto& a : annotations) { | ||
| if (eventCast<const ReactionEvent>(a)->relation().key == key |
There was a problem hiding this comment.
You'll crash dereferencing a null pointer if anything except ReactionEvent hits the list of annotations. That's not possible as yet but may become any time soon.
added 2 commits
April 8, 2020 14:34
should fix the incorrect flow height after opening the first room after starting.
KitsuneRal
approved these changes
Apr 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...and add ability to react to a message with already existing reactions.
Contributes to #596