Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Read marker is not shown at edits, reactions, redactions #687

Closed
KitsuneRal opened this issue Apr 9, 2020 · 0 comments · Fixed by #727
Closed

Read marker is not shown at edits, reactions, redactions #687

KitsuneRal opened this issue Apr 9, 2020 · 0 comments · Fixed by #727
Assignees
@KitsuneRal
Labels
bug/fix Quaternion doesn't work as expected
Projects
Quaternion 1

Comments

@KitsuneRal
Copy link
Member

KitsuneRal commented Apr 9, 2020 •
edited
Loading

Quaternion doesn't display the read marker line when the read marker is positioned on (after) a hidden event (a redaction, an edit or even a reaction) that's not shown on the screen because it's applied to an edited message.
@KitsuneRal KitsuneRal changed the title Edits don't play well with read marker Read marker is not shown at edits and redactions Jul 23, 2020
@KitsuneRal KitsuneRal transferred this issue from quotient-im/libQuotient Jul 23, 2020
@KitsuneRal KitsuneRal added this to Version 0.0.9.5 - To Do in Quaternion 1 Jul 23, 2020
@KitsuneRal KitsuneRal added the bug/fix Quaternion doesn't work as expected label Jul 23, 2020
@KitsuneRal KitsuneRal changed the title Read marker is not shown at edits and redactions Read marker is not shown at edits, reactions, redactions Jul 25, 2020
@KitsuneRal KitsuneRal moved this from Version 0.0.9.5 - To Do to In work in Quaternion 1 Dec 1, 2020
@KitsuneRal KitsuneRal self-assigned this Dec 1, 2020
KitsuneRal added a commit that referenced this issue Jan 13, 2021
@KitsuneRal
MessageEventModel: ensure read marker visibility
1240935 
ListView doesn't even position hidden (=with 0 size on either dimension)
events; so ensure that readMarkerVisualIndex property always points to
the latest non-hidden event before the read marker. Closes #687.
@KitsuneRal KitsuneRal mentioned this issue Jan 13, 2021
Merged
Quaternion 1 automation moved this from In work to Version 0.0.9.5 - Done Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@KitsuneRal KitsuneRal

Labels
bug/fix Quaternion doesn't work as expected
Projects
Quaternion 1
  
Version 0.0.95 - Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

New read marker quotient-im/Quaternion
1 participant
@KitsuneRal