Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add execution monitor to device app #1

Closed
wants to merge 2 commits into from
Closed

Conversation

dehanj
Copy link
Contributor

@dehanj dehanj commented Jun 22, 2023

Prevent instructions to be executed from the RAM outside the application.
This does change the sha512sum, and hence the key derivation.

@quite
Copy link
Owner

quite commented Jun 22, 2023

The TK1_MMIO_TK1_APP_{ADDR,SIZE} defines addresses where the app is loaded and its size respectively. You'd have to read out the values at these addresses, and then add those values together. Looks like the same for tillitis/tkey-device-signer#3

@quite
Copy link
Owner

quite commented Jun 22, 2023

But thank you, i plan to bring this in after current rework of app is done. We're defining exactly how key derivation should work etc.

@dehanj
Copy link
Contributor Author

dehanj commented Jun 26, 2023

Ah, good catch! It apparently went a bit fast on Thursday. I did it that way first and checked everything, then I for some reason wanted to use them the same way as TK1_RAM_{BASE,SIZE}...

Sure. Since I did it on all our repos (which I'm updating now) I thought I might as well do a PR for you. Thanks anyway.

@quite
Copy link
Owner

quite commented Dec 13, 2023

Fixed.

@quite quite closed this Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants