Execute commands consistently #699
Conversation
`executePartialCommand:` and `performOnDirectObject:indirectObject:` were each being called in two different places
Previously, these actions would only work correctly if run by the user from the interface. Now they should work in other contexts. fixes #623
|
Funny I should only stumble upon this now after years of QS use, just as you've open this... Seems like #670 also applies to objects grabbed with ⌘⎋. Would it be possible to fix that? Should be pretty easy I imagine. The ⌘⎋ command runs the |
Same goes for things opened with the |
Done. :-) |
|
Oooh the command line tool. Never actually used that. Any good? This all looks good. i'll keep playing |
Yeah, I forget it’s there most of the time, but I’ve rediscovered it in the past couple of weeks. It’s pretty cool. One time I love having it is when I’m in a plug-in’s directory doing |
|
I see the problem with the current command line tool. I'm assuming your change over there fixes it. Other than that, everything looks good. P.S. I use a different method to you for getting e.g. the current folder/file/whatever in terminal/whatever. I think this is probably my most used thing in Quicksilver since neurolepsy introduced it a year or so ago. You can use it on practically anything: Safari URLs, Terminal Windows, non-cocoa apps (MS Word etc.), Preview... |
Execute commands consistently
Yep.
Wow. I knew it was good, but I didn’t know it worked on Terminal’s current directory. I wonder if it’s only because we have it in the title bar? Anyway, cool. BTW, my favorite new trigger (now that this is merged): Finder Selection → Get Path (scoped to Finder only) |
I think so, I've thought it was to do with the title bar as well.
I wonder how many amazing triggers there are that not even we will On 23 February 2012 20:23, Rob McBroom <
|
This contains fixes for #623 and #670.
Long story short, you couldn’t have a trigger for something like “Finder Selection → Compress”. Now you can.
The problem was that there were different places that could execute an action and they didn’t all behave the same way. Rather than duplicate code, I’ve attempted to move things around so the same code is used no matter how an action is run.
I initially didn’t like
QSommanddoing so much with the interface controller, but I’ve talked myself into it. I can go into more detail if anyone is similarly uneasy.I’ve tried executing things every way I can think of (using the interface, triggers, droplets, encapsulated commands, commands saved to disk, commands run after delay) and they all seem to function correctly.