Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qlog: rename DefaultTracer to DefaultConnectionTracer #4556

Merged
merged 1 commit into from
Jun 5, 2024

Conversation

marten-seemann
Copy link
Member

There's a logging.Tracer and a logging.ConnectionTracer. It's confusing that qlog.DefaultTracer returns a ConnectionTracer.

Copy link

codecov bot commented Jun 5, 2024

Codecov Report

Attention: Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 85.15%. Comparing base (44e0147) to head (746c9f7).

Files Patch % Lines
qlog/qlog_dir.go 33.33% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4556      +/-   ##
==========================================
+ Coverage   85.12%   85.15%   +0.03%     
==========================================
  Files         154      154              
  Lines       14841    14843       +2     
==========================================
+ Hits        12633    12639       +6     
+ Misses       1700     1697       -3     
+ Partials      508      507       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann merged commit cc9a5ee into master Jun 5, 2024
34 checks passed
@marten-seemann marten-seemann deleted the qlog-rename-default-connection-tracer branch June 5, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants