add some Prometheus metrics #4534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
prometheus
branch
from
3fc3f5f
to
c49a92f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4534 +/- ##
=======================================
Coverage 85.15% 85.15%
=======================================
Files 154 154
Lines 14801 14801
=======================================
Hits 12603 12603
Misses 1690 1690
Partials 508 508 ☔ View full report in Codecov by Sentry. |
sukunrt
approved these changes
Jun 3, 2024
|
|
||
| // DefaultTracerWithRegisterer returns a callback that creates a metrics ConnectionTracer | ||
| // using a given Prometheus registerer. | ||
| func DefaultTracerWithRegisterer(registerer prometheus.Registerer) func(_ context.Context, p logging.Perspective, _ logging.ConnectionID) *logging.ConnectionTracer { |
There was a problem hiding this comment.
You can register the metrics here once instead of registering them in the callback. The current method also works but all but the first registration will return AlreadyRegistrationError so we can just register them upfront here.
There was a problem hiding this comment.
NewClientConnectionTracerWithRegisterer and NewServerConnectionTracerWithRegisterer are public functions though, so we'll need to register in these code paths as well (and catch the AlreadyRegisteredErrors there).
marten-seemann
force-pushed
the
prometheus
branch
from
c49a92f
to
a620f1a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4077.
TODO:
These metrics are by no means comprehensive, but it's a starting point that we can iterate from.