deprecate the ConnectionTracingKey #4532
Conversation
Applications can set their own tracing key using Transport.ConnContext.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4532 +/- ##
==========================================
+ Coverage 85.14% 85.16% +0.02%
==========================================
Files 154 154
Lines 14803 14803
==========================================
+ Hits 12603 12606 +3
+ Misses 1692 1689 -3
Partials 508 508 ☔ View full report in Codecov by Sentry. |
|
cc @sukunrt and @MarcoPolo, this will affect your use case of quic-go |
| var ConnectionTracingKey = connTracingCtxKey{} | ||
|
|
||
| // ConnectionTracingID is the type of the context value saved under the ConnectionTracingKey. | ||
| // Deprecated: Applications can set their own tracing key using Transport.ConnContext. | ||
| type ConnectionTracingID uint64 |
There was a problem hiding this comment.
What is the type of the context value now?
There was a problem hiding this comment.
For now, everything stays as is, it's just deprecated.
In the future, there won't be a quic.ConnectionTracingKey anymore. Instead, you will need to inject your own value on the context using Transport.ConnContext (see quic-go/docs#60).
|
Sounds good. Would help me (and maybe others) if there was a simple migration path call out in the release notes. 🙏 |
|
For sure, this will be called out in the release notes, and we'll link to the new section on the documentation page. |
Applications can set their own tracing key using
Transport.ConnContext.