Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

initialize the MTU discoverer when processing the transport parameters #4514

Merged
merged 1 commit into from
May 14, 2024

Commits on May 14, 2024

  1. initialize the MTU discoverer when processing the transport parameters

    On the client side, we always use the configured packet size. This comes
    with the risk of failing the handshake if the path doesn't support this
    MTU. If the server sends a max_udp_payload_size that's smaller than this
    size, we can safely ignore this: Obviously, the server still processed
    the (fully padded) Initial packet, despite claiming that it wouldn't do
    so.
    
    On the server side, there's no downside to using 1200 bytes until we
    received the client's transport parameters:
    * If the first packet didn't contain the entire ClientHello, all we can
    do is ACK that packet. We don't need a lot of bytes for that.
    * If it did, we will have processed the transport parameters and
    initialized the MTU discoverer.
    marten-seemann committed May 14, 2024
    Configuration menu
    Copy the full SHA
    b4a6d66 View commit details
    Browse the repository at this point in the history