Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire: write configured value of max_udp_payload_size transport parameter #4501

Merged
merged 1 commit into from
May 8, 2024

Conversation

marten-seemann
Copy link
Member

There's no reason the wire package should use the constant: It should be able to marshal any value configured.
Instead, we set the MaxUDPPayloadSize when initialising the connection.

No functional change expected.

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.16%. Comparing base (66f968b) to head (7838481).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4501      +/-   ##
==========================================
+ Coverage   85.15%   85.16%   +0.01%     
==========================================
  Files         154      154              
  Lines       14768    14770       +2     
==========================================
+ Hits        12575    12578       +3     
+ Misses       1688     1687       -1     
  Partials      505      505              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the tp-marshal-max-udp-payload-size branch from 73ff5c6 to 7838481 Compare May 8, 2024 04:01
@marten-seemann marten-seemann merged commit d1c1f18 into master May 8, 2024
34 checks passed
@marten-seemann marten-seemann deleted the tp-marshal-max-udp-payload-size branch May 11, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant