Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reject sending of DATAGRAM frames that exceed the current MTU #4497

Merged
merged 2 commits into from
May 7, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 7, 2024

Fixes #4496. Fixes #3222. Related: #4294.

TODO:

  • add an integration test

Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 82.35294% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 85.16%. Comparing base (f1b473d) to head (dee0fad).

Files Patch % Lines
connection.go 82.35% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4497      +/-   ##
==========================================
- Coverage   85.17%   85.16%   -0.01%     
==========================================
  Files         154      154              
  Lines       14756    14768      +12     
==========================================
+ Hits        12568    12577       +9     
- Misses       1683     1686       +3     
  Partials      505      505              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann marked this pull request as ready for review May 7, 2024 05:57
@marten-seemann marten-seemann changed the title reject sending of datagrams that exceed the current MTU reject sending of datagram frames that exceed the current MTU May 7, 2024
@marten-seemann marten-seemann changed the title reject sending of datagram frames that exceed the current MTU reject sending of DATAGRAM frames that exceed the current MTU May 7, 2024
@marten-seemann marten-seemann merged commit 66f968b into master May 7, 2024
35 checks passed
@marten-seemann marten-seemann deleted the check-mtu-send-datagram branch May 7, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

check MTU when queuing datagram How do I get the current max content size of Datagram Frame?
1 participant