http3: use the stream context to detect when the send side is closed #4489
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
http3-detect-stream-send-state-change
branch
from
94b46e1
to
40f8706
Compare
marten-seemann
force-pushed
the
http3-detect-stream-send-state-change
branch
from
40f8706
to
bbd4825
Compare
marten-seemann
commented
May 5, 2024
| d.mx.Unlock() | ||
| return nil, d.receiveErr | ||
| return nil, receiveErr |
There was a problem hiding this comment.
This fixes a race condition.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4489 +/- ##
==========================================
+ Coverage 84.92% 84.97% +0.06%
==========================================
Files 154 154
Lines 14692 14695 +3
==========================================
+ Hits 12476 12487 +11
+ Misses 1703 1697 -6
+ Partials 513 511 -2 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.