Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wire: use quicvarint.Parse when parsing frames #4484

Merged
merged 3 commits into from
May 5, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented May 4, 2024

name                  old time/op    new time/op    delta
ParseStreamAndACK-16     290ns ± 6%     244ns ± 4%  -15.80%  (p=0.000 n=9+10)
ParseOtherFrames-16      217ns ± 3%     171ns ± 3%  -21.43%  (p=0.000 n=9+10)

name                  old alloc/op   new alloc/op   delta
ParseStreamAndACK-16    1.58kB ± 0%    1.58kB ± 0%     ~     (all equal)
ParseOtherFrames-16       224B ± 0%      224B ± 0%     ~     (all equal)

name                  old allocs/op  new allocs/op  delta
ParseStreamAndACK-16      2.00 ± 0%      2.00 ± 0%     ~     (all equal)
ParseOtherFrames-16       6.00 ± 0%      6.00 ± 0%     ~     (all equal)

@marten-seemann marten-seemann force-pushed the optimize-frame-parser branch 2 times, most recently from e16591d to 3ad32f0 Compare May 4, 2024 09:05
@marten-seemann
Copy link
Member Author

Good thing we enabled ClusterFuzzLite PR fuzzing. It caught a pretty serious bug that would otherwise have gone unnoticed.

Copy link

codecov bot commented May 4, 2024

Codecov Report

Attention: Patch coverage is 98.33333% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 85.08%. Comparing base (a5adbd4) to head (e40a215).
Report is 2 commits behind head on master.

Files Patch % Lines
internal/wire/ack_frame.go 91.18% 3 Missing ⚠️
internal/wire/frame_parser.go 97.62% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4484      +/-   ##
==========================================
+ Coverage   84.92%   85.08%   +0.16%     
==========================================
  Files         154      154              
  Lines       14676    14719      +43     
==========================================
+ Hits        12463    12523      +60     
+ Misses       1700     1687      -13     
+ Partials      513      509       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann marked this pull request as ready for review May 4, 2024 09:31
@marten-seemann marten-seemann added this to the v0.44 milestone May 4, 2024
@marten-seemann marten-seemann merged commit f12ee48 into master May 5, 2024
34 checks passed
@marten-seemann marten-seemann deleted the optimize-frame-parser branch May 5, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants