Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: Pass original Conn to ConnContext #4480

Merged
merged 2 commits into from
May 3, 2024

Conversation

rthellend
Copy link
Contributor

Server.ConnContext should receive the original quic.Connection instead of an internal wrapper.

#4479

Copy link

codecov bot commented May 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.90%. Comparing base (3122ca0) to head (f5cd16a).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4480      +/-   ##
==========================================
- Coverage   84.92%   84.90%   -0.02%     
==========================================
  Files         154      154              
  Lines       14676    14676              
==========================================
- Hits        12463    12460       -3     
- Misses       1700     1702       +2     
- Partials      513      514       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we have a test for this? I don't want to break this again in the future.

@rthellend
Copy link
Contributor Author

Should we have a test for this? I don't want to break this again in the future.

I updated the test in http3/server_test.go

Copy link
Member

@marten-seemann marten-seemann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

I saw you downgraded back to v0.42. Would a v0.43.1 release be helpful for your project, once this PR is merged?

@marten-seemann marten-seemann linked an issue May 3, 2024 that may be closed by this pull request
@marten-seemann marten-seemann merged commit a5adbd4 into quic-go:master May 3, 2024
19 checks passed
@rthellend
Copy link
Contributor Author

Thanks!

I saw you downgraded back to v0.42. Would a v0.43.1 release be helpful for your project, once this PR is merged?

I would certainly use v0.43.1 if you release it, yes. Thanks!

marten-seemann pushed a commit that referenced this pull request May 3, 2024
* http3: Pass original Conn to ConnContext

#4479

* Update test to check conn value
@marten-seemann
Copy link
Member

@rthellend v0.43.1 is here: https://github.com/quic-go/quic-go/releases/tag/v0.43.1

@rthellend
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

http3 ConnContext regression in v0.43
2 participants