http3: move length limiting to the body #4439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marten-seemann
force-pushed
the
http3-length-limit-body
branch
from
ff10807
to
bab93a7
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4439 +/- ##
==========================================
+ Coverage 84.72% 84.75% +0.03%
==========================================
Files 152 152
Lines 14369 14372 +3
==========================================
+ Hits 12173 12180 +7
+ Misses 1693 1691 -2
+ Partials 503 501 -2 ☔ View full report in Codecov by Sentry. |
The length limit is a property of the (request and response) body. As such, it's better implemented there than by wrapping the HTTP stream.
marten-seemann
force-pushed
the
http3-length-limit-body
branch
from
bab93a7
to
07bfe66
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The length limit is a property of the (request and response) body. As such, it's better implemented there than by wrapping the HTTP stream.
Needed for the refactor for #3522.