http3: process 1xx status codes #4437
Conversation
Signed-off-by: mchtech <[email protected]>
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
| ) | ||
|
|
||
| // copy from net/http: support 1xx responses | ||
| trace := httptrace.ContextClientTrace(req.Context()) |
There was a problem hiding this comment.
We don't support tracing yet.
There was a problem hiding this comment.
Actually, this is fine. Let's keep it as is.
marten-seemann
changed the title
|
@mchtech Are you planning to address the review comments here? Would be great if we could include this fix in the next release! |
|
I will add an integration test in this weekend. |
Signed-off-by: mchtech <[email protected]>
mchtech
force-pushed
the
support-http-1xx
branch
from
64a0285
to
93a69e8
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4437 +/- ##
==========================================
- Coverage 84.68% 84.68% -0.00%
==========================================
Files 152 152
Lines 14384 14409 +25
==========================================
+ Hits 12180 12201 +21
- Misses 1701 1703 +2
- Partials 503 505 +2 ☔ View full report in Codecov by Sentry. |
Fix #4403
copy the impletation from the go standard library and add tests.