Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make stream state transitions observable on SendStream and ReceiveStream #4430

Closed
wants to merge 2 commits into from

Conversation

marten-seemann
Copy link
Member

Fixes #4428.

@marten-seemann marten-seemann marked this pull request as draft April 13, 2024 04:39
@marten-seemann marten-seemann force-pushed the stream-states branch 5 times, most recently from d653879 to ed4e52f Compare April 14, 2024 17:55
Copy link

codecov bot commented Apr 14, 2024

Codecov Report

Attention: Patch coverage is 72.34043% with 26 lines in your changes are missing coverage. Please review.

Project coverage is 84.68%. Comparing base (e48e1d4) to head (14ed493).

Files Patch % Lines
stream.go 53.85% 11 Missing and 1 partial ⚠️
receive_stream.go 81.08% 7 Missing ⚠️
send_stream.go 75.86% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4430      +/-   ##
==========================================
- Coverage   84.75%   84.68%   -0.07%     
==========================================
  Files         152      152              
  Lines       14371    14436      +65     
==========================================
+ Hits        12179    12224      +45     
- Misses       1691     1711      +20     
  Partials      501      501              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the stream-states branch 2 times, most recently from 1be06be to 66aa34f Compare April 17, 2024 08:27
@marten-seemann
Copy link
Member Author

We'll go with #4445 and #4460 instead.

@marten-seemann marten-seemann deleted the stream-states branch April 26, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

obtaining the stream state
1 participant