Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: expose a SingleDestinationRoundTripper #4424

Merged
merged 1 commit into from
Apr 11, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Apr 9, 2024

Depends on #4425. Like #4415, but without removing the hijackers. Part of #3522.

Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 71.71053% with 43 lines in your changes are missing coverage. Please review.

Project coverage is 84.76%. Comparing base (ee698b3) to head (982b611).
Report is 1 commits behind head on http3-hijacker-connection.

Files Patch % Lines
http3/roundtrip.go 69.61% 27 Missing and 4 partials ⚠️
http3/client.go 76.09% 7 Missing and 4 partials ⚠️
http3/response_writer.go 50.00% 1 Missing ⚠️
Additional details and impacted files
@@                      Coverage Diff                      @@
##           http3-hijacker-connection    #4424      +/-   ##
=============================================================
- Coverage                      84.80%   84.76%   -0.04%     
=============================================================
  Files                            152      152              
  Lines                          14386    14344      -42     
=============================================================
- Hits                           12199    12158      -41     
+ Misses                          1690     1684       -6     
- Partials                         497      502       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann changed the base branch from master to http3-hijacker-connection April 10, 2024 00:13
@marten-seemann marten-seemann force-pushed the http3-single-dest-roundtripper branch 2 times, most recently from 8228f0e to 94f2a37 Compare April 11, 2024 15:47
@marten-seemann marten-seemann marked this pull request as ready for review April 11, 2024 16:43
@marten-seemann marten-seemann changed the base branch from http3-hijacker-connection to master April 11, 2024 16:51
@marten-seemann marten-seemann merged commit da410a7 into master Apr 11, 2024
34 checks passed
@marten-seemann marten-seemann deleted the http3-single-dest-roundtripper branch April 11, 2024 17:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant