Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http3: cancel reading on request stream if request processing fails #4417

Merged
merged 1 commit into from
Apr 9, 2024

Conversation

marten-seemann
Copy link
Member

@marten-seemann marten-seemann commented Apr 8, 2024

No description provided.

@marten-seemann marten-seemann added this to the v0.43 milestone Apr 8, 2024
Copy link

codecov bot commented Apr 8, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 84.78%. Comparing base (eb310a6) to head (c0f3542).

Files Patch % Lines
http3/server.go 66.67% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4417      +/-   ##
==========================================
- Coverage   84.82%   84.78%   -0.04%     
==========================================
  Files         152      152              
  Lines       14398    14386      -12     
==========================================
- Hits        12213    12197      -16     
- Misses       1688     1691       +3     
- Partials      497      498       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@marten-seemann marten-seemann force-pushed the http3-cancel-read-side-of-failed-request branch from bd24121 to c0f3542 Compare April 9, 2024 20:19
@marten-seemann marten-seemann changed the base branch from http3-single-roundtripper-settings to master April 9, 2024 20:20
@marten-seemann marten-seemann merged commit ee698b3 into master Apr 9, 2024
18 checks passed
@marten-seemann marten-seemann deleted the http3-cancel-read-side-of-failed-request branch April 9, 2024 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant